github-code-scanning[bot] commented on code in PR #13014:
URL: https://github.com/apache/druid/pull/13014#discussion_r1148534798
##########
sql/src/main/java/org/apache/druid/sql/calcite/aggregation/builtin/BuiltinApproxCountDistinctSqlAggregator.java:
##########
@@ -82,27 +84,26 @@
final boolean finalizeAggregations
)
{
- // Don't use Aggregations.getArgumentsForSimpleAggregator, since it won't
let us use direct column access
- // for string columns.
- final RexNode rexNode = Expressions.fromFieldAccess(
- rexBuilder.getTypeFactory(),
- rowSignature,
- project,
- Iterables.getOnlyElement(aggregateCall.getArgList())
- );
+ final String aggregatorName = finalizeAggregations ?
Calcites.makePrefixedName(name, "a") : name;
+ final List<DimensionSpec> specs = new ArrayList<>();
+ final List<DimFilter> nonNullFilterList = new ArrayList<>();
Review Comment:
## Unread local variable
Variable 'List<DimFilter> nonNullFilterList' is never read.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4486)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
