rohangarg commented on code in PR #13974:
URL: https://github.com/apache/druid/pull/13974#discussion_r1149157434
##########
processing/src/main/java/org/apache/druid/frame/channel/ComposingWritableFrameChannel.java:
##########
@@ -105,6 +100,16 @@ public void write(FrameWithPartition frameWithPartition)
throws IOException
}
}
+ private void convertChannelSuppliersToReadOnly(int index)
Review Comment:
The reason for extracting out `convertToReadOnly` to an interface was that
currently we supply the whole output channel objects to a writable frame
channel, which seems like an overkill. Since the only thing we want is the
ability to release resources of the output channel, only that part can be
exposed to the writable channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
