hongming-xu commented on PR #13947: URL: https://github.com/apache/druid/pull/13947#issuecomment-1485380978
> ### Description > changes: > > * fixes inconsistent handling of byte[] values between `ExprEval.bestEffortOf` and `ExprEval.ofType`, which could cause `byte[]` values to end up as java `toString` values instead of base64 encoded strings in ingest time transforms > * improved `ExpressionTransform` binding to re-use `ExprEval.bestEffortOf` when evaluating a binding instead of throwing it away > * improved `ExpressionTransform` array handling in anticipation of [nested columns + arrays = array columns! #13803](https://github.com/apache/druid/pull/13803), added `RowFunction.evalDimension` that returns `List<String>` to back `Row.getDimension` and remove the automatic coercing of array types that would typically happen to `ExpressionTransform` now _unless_ using `Row.getDimension` > * improved `ExpressionPostAggregator` to use partial type information from decoration > * added some tests for `ExpressionTransform` with array inputs > > This PR has: > > * [x] been self-reviewed. > > * [x] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) > * [ ] a release note entry in the PR description. > * [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. > * [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. > * [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. > * [x] been tested in a test Druid cluster. hi, @clintropolis , the modification that adds evalDimension(Row row) method in RowFunction interface, Will it have an impact on the transform extensions that were previously implemented? References: (1)Adding a Transform Extension https://druid.apache.org/docs/latest/development/modules.html#adding-a-transform-extension -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
