clintropolis opened a new pull request, #13996:
URL: https://github.com/apache/druid/pull/13996

   ### Description
   #13988 made a mistake, the default needs to be v0 because old tasks on new 
workers would have null for the new field added to the string encoding strategy 
json. We can default to v1 in druid 27.
   
   #### Release note
   The `frontCoded` type of `stringEncodingStrategy` on `indexSpec`, has been 
improved with a new segment format version which typically has faster read 
speeds and reduced segment size. However, this improvement is backwards 
incompatible with Druid 25.0, so a new `formatVersion` option has been added, 
which defaults to the the current version `0`. This value can be specified 
explicitly as `1` to use start using the improved version after the ability to 
rollback to Druid 25.0 is no longer determined to be needed.
   
   <hr>
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] added documentation for new or modified features or behaviors.
   - [x] a release note entry in the PR description.
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to