abhishekagarwal87 commented on code in PR #13986:
URL: https://github.com/apache/druid/pull/13986#discussion_r1151530014
##########
extensions-contrib/kubernetes-overlord-extensions/src/test/java/org/apache/druid/k8s/overlord/KubernetesTaskRunnerTest.java:
##########
@@ -355,6 +368,243 @@ public void
testTheK8sRestartStateAndHandleJobsThatAlreadyCompletedWhileDown() t
verify(spyRunner, times(1)).run(eq(task));
}
+ @Test
+ public void testStreamTaskReports() throws Exception
+ {
+ Task task = makeTask();
+ K8sTaskId k8sTaskId = new K8sTaskId(task.getId());
+
+ Job job = mock(Job.class);
+ ObjectMeta jobMetadata = mock(ObjectMeta.class);
+ when(jobMetadata.getName()).thenReturn(k8sTaskId.getK8sTaskId());
+ JobStatus status = mock(JobStatus.class);
+ when(status.getActive()).thenReturn(1).thenReturn(null);
+ when(job.getStatus()).thenReturn(status);
+ when(job.getMetadata()).thenReturn(jobMetadata);
+
+ Pod peonPod = mock(Pod.class);
+ ObjectMeta metadata = mock(ObjectMeta.class);
+ when(metadata.getName()).thenReturn("peonPodName");
+ when(peonPod.getMetadata()).thenReturn(metadata);
+ PodStatus podStatus = mock(PodStatus.class);
+ when(podStatus.getPodIP()).thenReturn("SomeIP");
+ when(peonPod.getStatus()).thenReturn(podStatus);
+
+ K8sTaskAdapter adapter = mock(K8sTaskAdapter.class);
+ when(adapter.fromTask(eq(task))).thenReturn(job);
+
+ DruidKubernetesPeonClient peonClient =
mock(DruidKubernetesPeonClient.class);
+
+
when(peonClient.jobExists(eq(k8sTaskId))).thenReturn(Optional.fromNullable(null));
+ when(peonClient.launchJobAndWaitForStart(isA(Job.class), anyLong(),
isA(TimeUnit.class))).thenReturn(peonPod);
+ when(peonClient.getMainJobPod(eq(k8sTaskId))).thenReturn(peonPod);
+ when(peonClient.waitForJobCompletion(eq(k8sTaskId), anyLong(),
isA(TimeUnit.class))).thenReturn(new JobResponse(
+ job,
+ PeonPhase.SUCCEEDED
+ ));
Review Comment:
a simpler alternative could have been to extend `KubernetesTaskRunner` and
override `run()`. The `run` method would simply add the task to its state.
The thing with mocking like this is that its too tightly coupled with the
code. One has to keep track of all the calls with the arguments required even
though they are not being tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
