imply-elliott commented on code in PR #14031:
URL: https://github.com/apache/druid/pull/14031#discussion_r1158810493
##########
.github/workflows/reusable-revised-its.yml:
##########
@@ -117,8 +117,11 @@ jobs:
echo $DRUID_IT_IMAGE_NAME
docker save "$DRUID_IT_IMAGE_NAME" | gzip > druid-container-jdk${{
inputs.build_jdk }}.tar.gz
- - name: Load docker image
+ - name: Clean docker environment and Load docker image
run: |
+ echo "Stopping and pruning any remnant docker containers from
previous run"
+ docker ps -aq | xargs -r docker rm -f
+ docker system prune -af --volumes
Review Comment:
I had a PR open for this here: https://github.com/apache/druid/pull/13940
If you read Paul's comment here
https://github.com/apache/druid/pull/13940/files#r1139411707, he feels the same
way. I agree, it should probably be rolled in. It's also less heavy handed
than this, since this removes ALL containers on the runner, which includes some
pre-cached ones that save a little time. Honestly though, the pre-cached ones
are not that useful for us and the cleanup only takes a few seconds, so I
didn't put much weight on being less heavy handed for the older ITs, given
they're not long for the world.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
