imply-elliott commented on code in PR #13940:
URL: https://github.com/apache/druid/pull/13940#discussion_r1158897031


##########
.github/workflows/reusable-revised-its.yml:
##########
@@ -72,6 +72,15 @@ jobs:
           path: ./**/target
           key: maven-${{ runner.os }}-${{ inputs.build_jdk }}-targets-${{ 
github.sha }}
 
+      - name: Clean up docker

Review Comment:
   Maybe it would be more simple to just force stop and prune any containers 
matching the ones we know we'll be creating with the new ITs/`it.sh`?
   
   The files not owned by root is a direct result of running in containers, 
files created in them will often be created as `root`, and thus the runner user 
(ubuntu in this case) doesn't have permission to clean them, and as a result, 
the GHA runner can't clean up properly and artifacts get left around.  I threw 
it in as a good measure, since it doesn't really add any time or risk.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to