imply-cheddar commented on code in PR #13977:
URL: https://github.com/apache/druid/pull/13977#discussion_r1159213704
##########
processing/src/main/java/org/apache/druid/segment/column/DruidPredicateIndex.java:
##########
@@ -36,4 +36,12 @@
*/
@Nullable
BitmapColumnIndex forPredicate(DruidPredicateFactory matcherFactory);
+
+ static boolean checkSkipThreshold(@Nullable ColumnConfig columnConfig, int
numRowsToScan, int dictionaryCardinality)
Review Comment:
`shouldSkip`? `checkSkipThreshold` doesn't really tell me how I'm supposed
to interpret `true/false`. Does `true` mean that it exceeded the threshold and
therefore should be skipped? Or does it mean that it did not exceed the
threshold and should be used?
##########
processing/src/main/java/org/apache/druid/segment/column/NumericRangeIndex.java:
##########
@@ -43,4 +43,9 @@ BitmapColumnIndex forRange(
@Nullable Number endValue,
boolean endStrict
);
+
+ static boolean checkSkipThreshold(ColumnConfig columnConfig, int
numRowsToScan, int rangeSize)
+ {
+ return rangeSize > (int) Math.ceil(columnConfig.skipValueRangeIndexScale()
* numRowsToScan);
Review Comment:
You aren't doing the null check on this one. That intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
