clintropolis opened a new pull request, #14053:
URL: https://github.com/apache/druid/pull/14053

   ### Description
   
   Fixes a regression when ingesting 'v4' nested format columns caused by 
shuffling around some stuff when refactoring during review of #14014. I 
realized that I forgot to switch some of the tests back to using the v4 format, 
so Ive swapped the 'tsv' format tests to go back to using 'json' instead of 
'auto' to ingest the test data (there are no arrays in that data so there is no 
difference in functional behavior between v4 and the new common format).
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to