gianm commented on code in PR #14046:
URL: https://github.com/apache/druid/pull/14046#discussion_r1166184945
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/MSQTaskQueryMaker.java:
##########
@@ -140,23 +150,13 @@ public QueryResponse<Object[]> runQuery(final DruidQuery
druidQuery)
// This parameter is used internally for the number of worker tasks only,
so we subtract 1
final int maxNumWorkers = maxNumTasks - 1;
-
- final int rowsPerSegment = MultiStageQueryContext.getRowsPerSegment(
- queryContext,
- DEFAULT_ROWS_PER_SEGMENT
- );
-
- final int maxRowsInMemory = MultiStageQueryContext.getRowsInMemory(
- queryContext,
- DEFAULT_ROWS_IN_MEMORY
- );
-
- final IndexSpec indexSpec =
MultiStageQueryContext.getIndexSpec(queryContext, jsonMapper);
-
- final boolean finalizeAggregations =
MultiStageQueryContext.isFinalizeAggregations(queryContext);
+ final int rowsPerSegment =
MultiStageQueryContext.getRowsPerSegment(sqlQueryContext,
DEFAULT_ROWS_PER_SEGMENT);
Review Comment:
Sounds like a good idea. Looks like we never call it with any other default.
I'll change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
