LakshSingla opened a new pull request, #14101:
URL: https://github.com/apache/druid/pull/14101
### Description
This PR removes the property `maxResultsSize` from the S3OutputConfig. That
property was used to limit the max size that can be fetched from the S3 (and
used primarily in the durable storage of MSQ).
However, since we now chunk downloads from S3, we donot need such a
guardrail and the property can be removed from the config.
Moreover, a default chunk size of 100MiB has been introduced (earlier it was
calculated based on the value passed in the `maxResultsSize`). Removing
`maxResultsSize` also clears up the hurdles associated with calculating the
appropriate chunkSize.
#### Release note
<hr>
##### Key changed/added classes in this PR
* `S3OutputConfig`
* `RetryableS3OutputStream`
<hr>
This PR has:
- [x] been self-reviewed.
- [x] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
