abhishekagarwal87 commented on PR #14092: URL: https://github.com/apache/druid/pull/14092#issuecomment-1512673426
Instead of each caller passing through an acceptable response code, why not just do a retry (along with cache invalidation) on any 5xx? I think that's what happens after your change anyway. we wouldn't want to invalidate the cache if there is a 401. when the client needs to find a new leader, doesn't seem to be something that a class like LookupReferenceManager should decide. and if its just retries, we can do that for 503 and 504 no matter where the request comes from. 503 and 504 are more likely to be thrown by the proxy than from the leader service. Is there anything else in the response from the proxy that could be used to detect such setup and then we can use that for a targeted retry? If not, we can still retry (with cache invalidation for 503/504). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
