vtlim commented on code in PR #14094: URL: https://github.com/apache/druid/pull/14094#discussion_r1170369316
########## docs/configuration/logging.md: ########## @@ -107,8 +107,9 @@ The following example log4j2.xml is based upon the micro quickstart: > NOTE: > Although Druid shares the log4j configuration file task peon processes, Review Comment: Shares from whom to whom? Should it say "shares the log4j configuration file **between** task peon processes"? ########## docs/configuration/logging.md: ########## @@ -107,8 +107,9 @@ The following example log4j2.xml is based upon the micro quickstart: > NOTE: Review Comment: ```suggestion ``` ########## docs/configuration/logging.md: ########## @@ -107,8 +107,9 @@ The following example log4j2.xml is based upon the micro quickstart: > NOTE: > Although Druid shares the log4j configuration file task peon processes, -> the appenders in this file DO NOT take effect for peon processes. Peons always output logs to standard output. -> Middle Managers redirect task logs from standard output to [long-term storage](index.md#log-long-term-storage). +> the appenders in this file WILL NOT take effect for peon processes if there is no console appender defined. +> Peons always output logs to standard output. Middle Managers redirect task logs from standard output to +> [long-term storage](index.md#log-long-term-storage). Review Comment: This information seems more of a statement of fact; consider moving outside the note block. I think it also interrupts the idea flow to log-level settings in the following lines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
