clintropolis opened a new pull request, #14144:
URL: https://github.com/apache/druid/pull/14144

   ### Description
   Adjusts the `logicalDimensions` of the sampler response to re-use any 
explicitly specified dimension schemas on the request instead of always mapping 
to the default for that logical type. This fixes a bug where if 'json' is 
explicitly specified we still return 'auto' on the response of the logical 
schema.
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to