gianm commented on code in PR #14121:
URL: https://github.com/apache/druid/pull/14121#discussion_r1176022455
##########
extensions-core/azure-extensions/pom.xml:
##########
@@ -159,7 +159,7 @@
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
- <version>0.8.4</version>
+ <version>${jacoco.version}</version>
Review Comment:
IIRC, if the `<version>` is in `<pluginManagement>` in the main pom, then
the line doesn't need to be present at all here.
##########
docs/configuration/index.md:
##########
@@ -422,6 +422,12 @@ There are several emitters available:
##### Logging Emitter Module
+The use this emitter module, set `druid.emitter=logging`. The Logging emitter
will use the configured
+`druid.emitter.logging.loggerClass` to emit events. If the `loggerClass` is
set to `LoggingEmitter` (the default), the
Review Comment:
> The Logging emitter will use the configured
`druid.emitter.logging.loggerClass` to emit events. If the `loggerClass` is set
to `LoggingEmitter` (the default), the events are logged as a single `json`
object with a Marker…
All the `druid.emitter.logging.loggerClass` does is control the package name
of the logger (what gets printed for `%c` in the pattern). The new doc line
here makes it sound like it does more than that. Suggest something like:
> The `logging` emitter uses a log4j2 logger named
`druid.emitter.logging.loggerClass` to emit events. Each event is logged as a
single `json` object with a Marker…
Also, from looking at the code, I believe the existing doc is wrong: the
default is `org.apache.druid.java.util.emitter.core.LoggingEmitter` not
`LoggingEmitter`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
