gianm commented on code in PR #14183:
URL: https://github.com/apache/druid/pull/14183#discussion_r1180580658
##########
extensions-core/avro-extensions/src/main/java/org/apache/druid/data/input/avro/SchemaRegistryBasedAvroBytesDecoder.java:
##########
@@ -140,7 +140,10 @@ public GenericRecord parse(ByteBuffer bytes)
schema = parsedSchema instanceof AvroSchema ? ((AvroSchema)
parsedSchema).rawSchema() : null;
}
catch (IOException | RestClientException ex) {
- throw new ParseException(null, ex, "Failed to fetch Avro schema from
registry: %s", id);
+ throw new ParseException(null, ex, "Failed to fetch Avro schema from
registry: %s. Check if the id "
Review Comment:
Our log message style guide recommends bracketing interpolations, and saying
what they are, like `Failed to fetch Avro schema id[%s] from registry.`
##########
extensions-core/avro-extensions/src/main/java/org/apache/druid/data/input/avro/SchemaRegistryBasedAvroBytesDecoder.java:
##########
@@ -140,7 +140,10 @@ public GenericRecord parse(ByteBuffer bytes)
schema = parsedSchema instanceof AvroSchema ? ((AvroSchema)
parsedSchema).rawSchema() : null;
}
catch (IOException | RestClientException ex) {
- throw new ParseException(null, ex, "Failed to fetch Avro schema from
registry: %s", id);
+ throw new ParseException(null, ex, "Failed to fetch Avro schema from
registry: %s. Check if the id "
+ + "exists in the schema registry.
Otherwise it could mean that there is "
+ + "malformed data in the stream or
data that doesn’t conform to the schema "
Review Comment:
Use `'` instead of `’`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
