suneet-s opened a new pull request, #14200:
URL: https://github.com/apache/druid/pull/14200

   ### Description
   
   This change makes it so that extension writers can now optionally bind extra 
service dimensions. This is useful if an extension wants to bind service 
dimensions that are only relevant to one node type, but not the others. This 
will allow the extension to be listed in the extension load list in the common 
runtime properties without needing to inject invalid properties for all the 
other services where the dimensions are not relevant.
   
   Developer facing docs are added to the `ExtraServiceDimensions` class.
   
   #### Release note
   NEW: Extension developers can optionally bind extra service dimensions to be 
emitted by the service emitter.
   
   <hr>
   
   
   This PR has:
   
   - [ ] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [x] added documentation for new or modified features or behaviors.
   - [x] a release note entry in the PR description.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to