georgew5656 opened a new pull request, #14205:
URL: https://github.com/apache/druid/pull/14205
We add taskId/taskType/groupid/dataSource annotations to jobs launched with
the K8s task runner for information but its nice to have these in labels as
well to e.g. filter jobs by data source in kubectl or in something like
kubecost. (These tools generally support grouping by labels more than grouping
by annotations).
These key/value pairs are all pretty small so I don't think this will cause
any issues with the size of the spec.
### Description
Add the same key/value pairs that we add to annotations to labels as well
(excluding the actual task blob)
#### Release note
- Add additional labels to K8s Task Runner jobs
##### Key changed/added classes in this PR
Update the PodTemplateTaskAdapter to include some additional helpful labels
This PR has:
- [X ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [X ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
