gianm commented on code in PR #14252:
URL: https://github.com/apache/druid/pull/14252#discussion_r1190481465
##########
owasp-dependency-check-suppressions.xml:
##########
@@ -806,4 +806,13 @@
<!-- seems not applicable to plugin -->
<cve>CVE-2022-45048</cve>
</suppress>
+ <suppress>
+ <notes><![CDATA[
+ file name: hadoop-client-runtime-3.3.5.jar
+ ]]></notes>
+ <!-- this one is windows only?
https://nvd.nist.gov/vuln/detail/CVE-2022-26612 -->
+ <cve>CVE-2022-26612</cve>
+ <!-- this one seems to apply to backend server?
https://nvd.nist.gov/vuln/detail/CVE-2023-25613 -->
Review Comment:
Could we upgrade the hadoop client?
If we can't do any of this stuff, then I agree this appears to be about the
backend server, which presumably we wouldn't be using in a client. So I think a
suppression is OK. But it should be a last resort due to the severity. (Even if
it's a false positive, suppressed high-sev false positives creates a bunch of
work for downstream consumers that run their own scans.)
Ditch the "?" in the comment, though, once this analysis is complete. We
need to be confident when suppressing things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
