clintropolis commented on code in PR #14262:
URL: https://github.com/apache/druid/pull/14262#discussion_r1191777885
##########
processing/src/test/java/org/apache/druid/segment/TestHelper.java:
##########
@@ -484,6 +484,17 @@ public static Map<String, Object> makeMap(boolean
explicitNulls, Object... vals)
return theVals;
}
+ public static Map<String, Object> makeMapWithExplicitNull(Object... vals)
Review Comment:
ah yeah, that makes sense, but seems like it somewhat defeats the purpose of
having the flag sine it relates to how to process `null`. Maybe i should just
transition callers to use the renamed one and then its never ambiguous
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
