vtlim commented on code in PR #14283: URL: https://github.com/apache/druid/pull/14283#discussion_r1194470062
########## docs/assets/tutorial-deletion-03.png: ########## Review Comment: Since this screenshot is being updated, could you update the other two as well to have the same look and feel within the doc? ########## docs/tutorials/tutorial-delete-data.md: ########## @@ -103,29 +103,17 @@ In the [segments view](http://localhost:8888/unified-console.html#segments), cli The top of the info box shows the full segment ID, e.g. `deletion-tutorial_2015-09-12T14:00:00.000Z_2015-09-12T15:00:00.000Z_2019-02-28T01:11:51.606Z` for the segment of hour 14. -Let's disable the hour 13 and 14 segments by sending a POST request to the Coordinator with this payload - -```json -{ - "segmentIds": - [ - "deletion-tutorial_2015-09-12T13:00:00.000Z_2015-09-12T14:00:00.000Z_2019-05-01T17:38:46.961Z", - "deletion-tutorial_2015-09-12T14:00:00.000Z_2015-09-12T15:00:00.000Z_2019-05-01T17:38:46.961Z" - ] -} -``` - -This payload json has been provided at `quickstart/tutorial/deletion-disable-segments.json`. Submit the POST request to Coordinator like this: - +Let's disable the last two segments, hour 22 and 23 segments, by sending a POST request to the Coordinator with this payload: ```bash -curl -X 'POST' -H 'Content-Type:application/json' -d @quickstart/tutorial/deletion-disable-segments.json http://localhost:8081/druid/coordinator/v1/datasources/deletion-tutorial/markUnused +unusedSegmentIds=$(curl -X 'GET' -H 'Content-Type:application/json' http://localhost:8081/druid/coordinator/v1/datasources/deletion-tutorial/segments | jq '.[-2:]') Review Comment: Since these are two separate commands, we should include them separately. Could introduce it with something like the following: >Disable the last two segments, hour 22 and 23 segments, by sending a POST request to the Coordinator with the corresponding segment IDs. >The following command queries the Coordinator for segment IDs and uses `jq` to parse and extract the IDs of the last two segments. The segment IDs are stored in an environment variable named `unusedSegmentIds`. > [code block with cmd] > >The following POST request marks the segments unused: ########## docs/tutorials/tutorial-delete-data.md: ########## @@ -103,29 +103,17 @@ In the [segments view](http://localhost:8888/unified-console.html#segments), cli The top of the info box shows the full segment ID, e.g. `deletion-tutorial_2015-09-12T14:00:00.000Z_2015-09-12T15:00:00.000Z_2019-02-28T01:11:51.606Z` for the segment of hour 14. -Let's disable the hour 13 and 14 segments by sending a POST request to the Coordinator with this payload - -```json -{ - "segmentIds": - [ - "deletion-tutorial_2015-09-12T13:00:00.000Z_2015-09-12T14:00:00.000Z_2019-05-01T17:38:46.961Z", - "deletion-tutorial_2015-09-12T14:00:00.000Z_2015-09-12T15:00:00.000Z_2019-05-01T17:38:46.961Z" - ] -} -``` - -This payload json has been provided at `quickstart/tutorial/deletion-disable-segments.json`. Submit the POST request to Coordinator like this: - +Let's disable the last two segments, hour 22 and 23 segments, by sending a POST request to the Coordinator with this payload: ```bash -curl -X 'POST' -H 'Content-Type:application/json' -d @quickstart/tutorial/deletion-disable-segments.json http://localhost:8081/druid/coordinator/v1/datasources/deletion-tutorial/markUnused +unusedSegmentIds=$(curl -X 'GET' -H 'Content-Type:application/json' http://localhost:8081/druid/coordinator/v1/datasources/deletion-tutorial/segments | jq '.[-2:]') Review Comment: We should also list at the top of the doc that jq is a prerequisite ########## docs/assets/tutorial-deletion-03.png: ########## Review Comment: That said, screenshot 02 is not very explanatory. The preceding text states: >After that command completes, you should see that the segment for hour 18 and 19 have been disabled: But someone has to scrutinize to figure out what they should be looking for. We could update the text with something like the following: >When the request completes, the [Segments view of the web console](http://localhost:8888/unified-console.html#segments) no longer displays the segments for hours 18 and 19. ########## docs/assets/tutorial-deletion-03.png: ########## Review Comment: Screenshot 01 (not sure why these are out of order) is also no longer applicable. The text has this: >In the [segments view](http://localhost:8888/unified-console.html#segments), click the arrow on the left side of one of the remaining segments to expand the segment entry: But I think there is now a segments view rather than the drop down:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
