clintropolis opened a new pull request, #14296:
URL: https://github.com/apache/druid/pull/14296
### Description
Fixes `SegmentAnalyzer` to be more resilient and prefer to use 'error' flag
and messages on `ColumnAnalysis` rather than exploding, which protects the
downstream broker SQL metadata cache from getting stuck if any segments run
into bugs or other unexpected errors during column analysis.
This was uncovered bug a bug in 'auto' column schema which was incorrectly
calling an 'all null' `DictionaryEncodedColumn` a `COMPLEX` type resulting in a
class cast exception while doing complex analysis since it did not implement
`ComplexColumn`. However, there were a handful of other places which might have
thrown exceptions while processing columns, so I've updated things to more
aggressively handle any errors that might be thrown and turn them into
ColumnAnalysis with the 'error' state set.
I made a builder for `ColumnAnalysis` while I was here to clean up a few
things, and also made these internal segment metadata queries no longer utilize
the broker parallel merge pool, both to reserve capacity for actual user
queries, and also because we aren't actually merging these segment metadata
results, so it is rather pointless to use anyway.
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
