tejaswini-imply commented on code in PR #14158:
URL: https://github.com/apache/druid/pull/14158#discussion_r1195909852
##########
.github/workflows/reusable-standard-its.yml:
##########
@@ -89,7 +89,7 @@ jobs:
${MVN} verify -pl integration-tests -P integration-tests ${{
inputs.testing_groups }} -Djvm.runtime=${{ inputs.runtime_jdk }}
-Dit.indexer=${{ inputs.use_indexer }} ${MAVEN_SKIP} -Doverride.config.path=${{
inputs.override_config_path }}
- name: Debug IT
- if: steps.run-it.conclusion == 'failure'
+ if: ${{ failure() && steps.run-it.conclusion == 'failure' }}
Review Comment:
https://docs.github.com/en/actions/learn-github-actions/expressions#failure-with-conditions
It needs `failure()` check, else this step gets skipped, which is happening so
far
https://github.com/apache/druid/actions/runs/4852046053/jobs/8694134189?pr=14137.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
