clintropolis commented on code in PR #14319:
URL: https://github.com/apache/druid/pull/14319#discussion_r1203510841
##########
processing/src/main/java/org/apache/druid/segment/column/Types.java:
##########
@@ -112,4 +113,12 @@ public static <T extends TypeDescriptor> boolean either(
return (typeSignature1 != null && typeSignature1.is(typeDescriptor)) ||
(typeSignature2 != null && typeSignature2.is(typeDescriptor));
}
+
+ public static class IncompatibleTypeException extends IAE
Review Comment:
hmm, in this particular PR the thing isn't user facing really because its
happening inside the brokers segment metadata cache that powers the SQL schema
and is happening in the background. This logic does not happen in user queries.
The callers of `ExpressionTypeConversion` that also now throw this exception
instead of `IAE` are i guess potentially user facing (though could also happen
in ingest time transforms), though im not really sure this is an exception that
should be thrown directly to users, rather it should probably be caught by
something and decorated with additional context to indicate like what the
offending expression was, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
