findingrish commented on code in PR #14192:
URL: https://github.com/apache/druid/pull/14192#discussion_r1204379884
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskClientAsyncImpl.java:
##########
@@ -145,10 +145,16 @@ public ListenableFuture<Boolean> stopAsync(final String
id, final boolean publis
{
return makeRequest(id, new RequestBuilder(HttpMethod.POST, "/stop" +
(publish ? "?publish=true" : "")))
.onSuccess(r -> true)
- .onHttpError(e -> Either.value(false))
- .onNotAvailable(e -> Either.value(false))
+ .onHttpError(e -> {
+ log.warn("Task [%s] coundln't be stopped because of http request
failure.", id);
+ return Either.value(false);
+ })
+ .onNotAvailable(e -> {
+ log.warn("Task [%s] coundln't be stopped because it is not
available.", id);
Review Comment:
this corresponds to `ServiceNotAvailableException` which is thrown when the
service locator returns empty set of locations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
