techdocsmith commented on code in PR #14341: URL: https://github.com/apache/druid/pull/14341#discussion_r1204763173
########## docs/multi-stage-query/reference.md: ########## @@ -192,12 +192,13 @@ The following ISO 8601 periods are supported for `TIME_FLOOR` and the string con - PT1H - PT6H - P1D -- P1W +- P1W* - P1M - P3M - P1Y -For more information about partitioning, see [Partitioning](concepts.md#partitioning-by-time). +For more information about partitioning, see [Partitioning](concepts.md#partitioning-by-time). <br /><br /> +*Avoid using `P1W` due to alignment complications with months and years. Review Comment: ```suggestion *Avoid partitioning by week, `P1W`, because weeks don't align neatly with months and years, making it difficult to partition by coarser granularities later. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
