xvrl commented on code in PR #14281:
URL: https://github.com/apache/druid/pull/14281#discussion_r1210869846
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentTransactionalInsertAction.java:
##########
@@ -257,11 +260,27 @@ public SegmentPublishResult perform(Task task,
TaskActionToolbox toolbox)
segment.getShardSpec() == null ? null :
segment.getShardSpec().getType()
);
toolbox.getEmitter().emit(metricBuilder.build("segment/added/bytes",
segment.getSize()));
+ // Emit the segment related metadata using the configured emitters
+ this.emitSegmentMetadata(segment, toolbox);
Review Comment:
can we add a comment that captures the limitation that @gianm pointed out,
explaining that some segmentmetadata events may not be captured in the event of
server crash?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
