amaechler commented on code in PR #14355:
URL: https://github.com/apache/druid/pull/14355#discussion_r1213299903
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/RecordSupplierInputSource.java:
##########
@@ -68,16 +70,20 @@ public RecordSupplierInputSource(
this.recordSupplier = recordSupplier;
this.useEarliestOffset = useEarliestOffset;
this.iteratorTimeoutMs = iteratorTimeoutMs;
+
try {
assignAndSeek(recordSupplier);
}
catch (InterruptedException e) {
- throw new SamplerException(e, "Exception while seeking to partitions");
+ throw new SamplerException(e, "Thread interrupted while seeking to
partitions");
+ }
+ catch (StreamException e) {
+ throw new SamplerException(e, "Exception creating
RecordSupplierInputSource while seeking to partitions: %s",
Throwables.getRootCause(e).getMessage());
Review Comment:
Updated and moved the try / catch. I played for a while with different
exception messages based on the stage (which of the three functions is called),
but in the end, I didn't think the added boilerplate was worth the value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
