LakshSingla opened a new pull request, #14370:
URL: https://github.com/apache/druid/pull/14370

   ### Description
   
   MSQ queries return the results in the query reports. Querying large data 
sources can generate a lot of rows, all of which will get materialized in the 
query reports, causing them to grow very large. This PR limits the results of 
the SELECT queries that we put in the reports.
   
   Note: Only way to fetch the complete result set after this change would be 
to run the query using the native engine, however, we might add a way to 
execute long-running queries that post their complete results in a different. 
Therefore the rows in the reports would serve as a preview to the actual result 
set.
   
   #### Release note
   SELECT queries executed using MSQ generate only a subset of the results in 
the query reports. 
   
   
   
   
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * `ControllerImpl`
   
   <hr>
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not 
all of these items apply to every PR. Remove the items which are not done or 
not relevant to the PR. None of the items from the checklist below are strictly 
necessary, but it would be very helpful if you at least self-review the PR. -->
   
   This PR has:
   
   - [x] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [x] a release note entry in the PR description.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to