317brian commented on PR #14411: URL: https://github.com/apache/druid/pull/14411#issuecomment-1591532708
Thanks for taking a look @petermarshallio! * For admonitions: yes, Docusaurus does support different types of them, and we can sort out the different ones in a follow up PR. * This repo is unstyled because it's purpose is to provide a preview of the rendered markdown. The repo that builds the prod site, `apache/druid-website-src`, the styling has been implemented: https://deploy-preview-1--frabjous-kulfi-9f6ae5.netlify.app/. We'll have a follow up PR to style this. * The hidden section, thanks for catching that! I must have missed deleting it from this PR. The pages will still get built after I delete them, but they aren't shown in the sidebar on the current live site. * Thanks for testing the scripts! I'll look into the spellcheck one. Will need someone else to chime in about the link checker cause I have open questions about that one too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
