clintropolis commented on code in PR #14204:
URL: https://github.com/apache/druid/pull/14204#discussion_r1230710308
##########
processing/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java:
##########
@@ -1310,9 +1327,22 @@ public long getSlowestPartitionInitializedTime()
private final int inputSequences;
+ public enum State
+ {
+ SCHEDULED,
+ STARTED,
+ PARTITON_MERGE_SCHEDULED,
+ FINAL_MERGE_SCHEDULED
+ }
+
+ private State state;
+ private long stateStartTime;
+
MergeCombineMetricsAccumulator(int inputSequences)
{
this.inputSequences = inputSequences;
+ this.partitionMetrics = Collections.emptyList();
+ this.mergeMetrics = new MergeCombineActionMetricsAccumulator();
Review Comment:
#14426 also initializes these, though externally, so we should either remove
those external calls or these constructor initializations (i think its a bit
cleaner to be handled in the constructor like is done in this PR, but don't
care too much either way)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
