suneet-s commented on PR #14443: URL: https://github.com/apache/druid/pull/14443#issuecomment-1595336889
Thanks for your first contribution to Druid @YongGang ! Instead of introducing one monitor per service, I'd recommend creating a single monitor that can be installed on every service. This will make it easier to use as an operator can set this monitor in the common runtime properties instead of having to configure it per service. Instead of the `leader/count` metric, what do you think of introducing a `druid/heartbeat` metric that can be annotated with dimensions like `leader` for the coordinator / overlord, or `task_id` for the peons, or `disabled` for middle managers? We do not need to implement all these ideas in this PR, but I think a heartbeat metric will be more flexible than a metric that is scoped to the leader. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
