imply-cheddar commented on code in PR #14004:
URL: https://github.com/apache/druid/pull/14004#discussion_r1233484239
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQInsertTest.java:
##########
@@ -1079,7 +1074,7 @@ public void
testInsertLimitWithPeriodGranularityThrowsException()
+ "LIMIT 50 "
+ "PARTITIONED BY MONTH")
.setExpectedValidationErrorMatcher(CoreMatchers.allOf(
- CoreMatchers.instanceOf(SqlPlanningException.class),
+ CoreMatchers.instanceOf(DruidException.class),
ThrowableMessageMatcher.hasMessage(CoreMatchers.containsString(
"INSERT and REPLACE queries cannot have a LIMIT
unless PARTITIONED BY is \"ALL\""))
Review Comment:
Yes, it could. I'm not sure which, but you are either seeing stuff left
behind when I first started converting tests and hadn't yet build the Matcher
to make it simpler (and I missed it in going back to simplify). OR, with fixing
the conflicts after 2 months dormant, I will admit that I didn't have all of
the context still in my head and perhaps did something a bit rote. Either way,
it's much simpler to switch to the `invalidSqlContains()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
