adarshsanjeev opened a new pull request, #14446:
URL: https://github.com/apache/druid/pull/14446
This PR makes some changes to the MSQ auto cleaner to add support for a
"query results" directory in durable storage. This change will allow us to
store query results as well on durable storage in the future.
The new structure of durable storage is now
- `<controller_id>/durable-shuffle-intermediate/<intermediate file path>`:
This contains the intermediate stage and super sorter files. Essentially,
everything we used durable storage for till now. This would be cleaned by the
auto cleaner once the task has finished running.
- `<controller_id>/query-results/<file>`: This will contain query results in
the future. This would be cleaned by the auto cleaner once the task has been
dropped from the list of known tasks.
This should not break backward compatibility as the structure is the same as
before. An earlier version of overlord should simply delete the new query
results directory as well.
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
