techdocsmith commented on code in PR #14419:
URL: https://github.com/apache/druid/pull/14419#discussion_r1235986669
##########
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/01-druidapi-package-intro.ipynb:
##########
Review Comment:
This notebook breaks at line 227 now b/c it is before any ingestion happens.
`display.tables()` fails as follows:
```
---------------------------------------------------------------------------
AttributeError Traceback (most recent call last)
Cell In[10], line 1
----> 1 display.tables()
File /opt/conda/lib/python3.10/site-packages/druidapi/display.py:146, in
DisplayClient.tables(self, schema)
145 def tables(self, schema=consts.DRUID_SCHEMA):
--> 146 self._druid.sql._tables_query(schema).show(display=self)
File /opt/conda/lib/python3.10/site-packages/druidapi/sql.py:397, in
SqlQueryResult.show(self, non_null, display)
395 data = self.non_null
396 if not data:
--> 397 data = self.as_array
398 if not data:
399 display.alert('Query returned no results')
File /opt/conda/lib/python3.10/site-packages/druidapi/sql.py:344, in
SqlQueryResult.as_array(self)
342 rows = []
343 for obj in self.rows:
--> 344 rows.append([v for v in obj.values()])
345 return rows
346 else:
AttributeError: 'str' object has no attribute 'values'
```
I'd actually move this into a folder `11-utilities` or something.
I would move the `00-gettings-started.ipynb` from the API folder to this one
since it is the "notebook version of the quickstart"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
