suneet-s commented on code in PR #14443:
URL: https://github.com/apache/druid/pull/14443#discussion_r1237955927


##########
docs/operations/metrics.md:
##########
@@ -326,6 +326,12 @@ If `emitBalancingStats` is set to `true` in the 
Coordinator [dynamic configurati
 
 ## General Health
 
+### Service Health
+
+|Metric|Description|Dimensions|Normal Value|
+|------|-----------|----------|------------|
+|`druid/heartbeat`| Report service health. For Overlord/Coordinator, the 
dimension is leader count. `ServiceStatusMonitor` must be enabled. 
|`heartbeatType`|1|

Review Comment:
   I don't have a strong preference. We could also just call the metric 
`heartbeat` instead of `druid/hearbeat`
   
   The Druid process might be running in a container, in which case `server` 
can be misleading. Do you have some examples in mind of other metrics that 
would live under `cluster/` that wouldn't make sense under `druid/`? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to