kfaraz opened a new pull request, #14468:
URL: https://github.com/apache/druid/pull/14468
### Description
The logs from `HttpServerInventoryView` and the underlying
`ChangeRequestHttpSyncer` are often too cryptic and the metrics are
insufficient.
### Bug
Description: If a server is removed during
`HttpServerInventoryView.serverInventoryInitialized`, the initialization gets
stuck as this server is never synced. The method eventually times out (default
250s).
Fix: Mark a server as stopped if it is removed. `serverInventoryInitialized`
only waits for non-stopped servers to sync.
### Changes
- Add a new single-threaded monitoring executor in `HttpServerInventoryView`
to emit metrics and reset unhealthy servers. Before this PR, server reset used
to happen on the same executor which is used for syncing with servers.
- Add new metrics
- `cluster/serverview/healthy`: tracks if the server view is syncing
properly with a server
- `cluster/serverview/unstable/time`: tracks the time in millis for which
sync with a server has been unstable
- Improve logging in `HttpServerInventoryView` and `ChangeRequestHttpSyncer`
- Refactor for readability
- Add some static utility methods in `DateTimes` to compute elapsed time.
### Release note
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
