rohangarg commented on code in PR #14453:
URL: https://github.com/apache/druid/pull/14453#discussion_r1238673527


##########
sql/src/main/java/org/apache/druid/sql/calcite/schema/SegmentMetadataCache.java:
##########
@@ -707,14 +709,19 @@ private long 
recomputeIsRealtime(ImmutableSet<DruidServerMetadata> servers)
   private Set<SegmentId> refreshSegmentsForDataSource(final String dataSource, 
final Set<SegmentId> segments)
       throws IOException
   {
+    final long startTimeNanos = System.nanoTime();

Review Comment:
   Since you've given this enough thought - probably Guava's `StopWatch` is a 
good utility to use here. It is also used at a couple of more place and 
provides the elapsed and conversion methods as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to