cryptoe commented on code in PR #14449:
URL: https://github.com/apache/druid/pull/14449#discussion_r1239339195
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/WorkerStorageParameters.java:
##########
@@ -71,6 +74,7 @@ public static WorkerStorageParameters
createProductionInstance(
)
{
long tmpStorageBytesPerTask =
injector.getInstance(TaskConfig.class).getTmpStorageBytesPerTask();
+ log.info("Creating WorkerStorageParameters with value of
tmpStorageBytesPerTask: [%s]", tmpStorageBytesPerTask);
Review Comment:
```suggestion
```
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/WorkerStorageParameters.java:
##########
@@ -71,6 +74,7 @@ public static WorkerStorageParameters
createProductionInstance(
)
{
long tmpStorageBytesPerTask =
injector.getInstance(TaskConfig.class).getTmpStorageBytesPerTask();
+ log.info("Creating WorkerStorageParameters with value of
tmpStorageBytesPerTask: [%s]", tmpStorageBytesPerTask);
Review Comment:
I think this info line may not be needed.
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/WorkerStorageParameters.java:
##########
@@ -97,6 +101,8 @@ public static WorkerStorageParameters createInstance(
Preconditions.checkArgument(tmpStorageBytesPerTask > 0, "Temporary storage
bytes passed: [%s] should be > 0", tmpStorageBytesPerTask);
long intermediateSuperSorterStorageMaxLocalBytes =
computeUsableStorage(tmpStorageBytesPerTask);
+ log.info("Useable storage: [%s]",
intermediateSuperSorterStorageMaxLocalBytes);
Review Comment:
```suggestion
log.info("Intermediate super sorter local storage size: %d bytes",
intermediateSuperSorterStorageMaxLocalBytes);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
