LakshSingla commented on code in PR #13952:
URL: https://github.com/apache/druid/pull/13952#discussion_r1241583406
##########
processing/src/main/java/org/apache/druid/frame/segment/FrameCursorUtils.java:
##########
@@ -67,4 +76,58 @@ public static Filter buildFilter(@Nullable Filter filter,
Interval interval)
);
}
}
+
+ /**
+ * Writes a {@link Cursor} to a sequence of {@link Frame}. This method
iterates over the rows of the cursor,
+ * and writes the columns to the frames
+ *
+ * @param cursor Cursor to write to the frame
+ * @param frameWriterFactory Frame writer factory to write to the frame.
+ * Determines the signature of the rows that
are written to the frames
+ */
+ public static Sequence<Frame> cursorToFrames(
+ Cursor cursor,
+ FrameWriterFactory frameWriterFactory
+ )
+ {
+
+ return Sequences.simple(
+ () -> new Iterator<Frame>()
+ {
+ @Override
+ public boolean hasNext()
+ {
+ return !cursor.isDone();
+ }
+
+ @Override
+ public Frame next()
+ {
+ // Makes sure that cursor contains some elements prior. This
ensures if no row is written, then the row size
+ // is larger than the MemoryAllocators returned by the provided
factory
+ if (!hasNext()) {
+ throw new NoSuchElementException();
+ }
+ boolean firstRowWritten = false;
+ Frame frame;
+ try (final FrameWriter frameWriter =
frameWriterFactory.newFrameWriter(cursor.getColumnSelectorFactory())) {
+ while (!cursor.isDone()) {
+ if (!frameWriter.addSelection()) {
+ break;
+ }
+ firstRowWritten = true;
+ cursor.advance();
+ }
+
+ if (!firstRowWritten) {
+ throw new ISE("Row size is greater than the frame size.");
Review Comment:
Yes this can be seen at the top level. Refactored with the DruidException
and a more actionable error message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
