[GitHub] [druid] jon-wei commented on a diff in pull request #14463: Support complex variance object inputs for variance SQL agg function

[via GitHub]

jon-wei commented on code in PR #14463:
URL: https://github.com/apache/druid/pull/14463#discussion_r1242935757


##########
extensions-core/stats/src/main/java/org/apache/druid/query/aggregation/variance/sql/BaseVarianceSqlAggregator.java:
##########
@@ -137,21 +149,77 @@ public Aggregation toDruidAggregation(
     );
   }
 
+  private static class VarPopSqlAggFunction extends SqlAggFunction

Review Comment:
   Changed this to use aggregatorBuilder and added a comment about this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org