kfaraz commented on code in PR #14488: URL: https://github.com/apache/druid/pull/14488#discussion_r1243461462
########## server/src/test/java/org/apache/druid/client/BrokerInternalQueryConfigTest.java: ########## @@ -33,18 +33,20 @@ import org.apache.druid.guice.LazySingleton; import org.apache.druid.jackson.DefaultObjectMapper; import org.apache.druid.segment.TestHelper; -import org.junit.Assert; -import org.junit.Test; +import org.junit.jupiter.api.Test; import java.util.HashMap; import java.util.Map; -public class BrokerInternalQueryConfigTest +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertThrows; + +class BrokerInternalQueryConfigTest Review Comment: Does JUnit5 require/recommend the test classes and methods to be package-protected? If not, we can continue to keep the classes and methods as `public` to reduce the footprint of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
