amaechler commented on code in PR #14505:
URL: https://github.com/apache/druid/pull/14505#discussion_r1247183476
##########
sql/src/main/java/org/apache/druid/sql/calcite/expression/builtin/RegexpExtractOperatorConversion.java:
##########
@@ -74,16 +77,29 @@ public DruidExpression toDruidExpression(
if (arg.isSimpleExtraction() && patternExpr.isLiteral() &&
(indexExpr == null || indexExpr.isLiteral())) {
final String pattern = (String) patternExpr.getLiteralValue();
- return arg.getSimpleExtraction().cascade(
- new RegexDimExtractionFn(
- // Undo the empty-to-null conversion from patternExpr
parsing (patterns cannot be null, even in
- // non-SQL-compliant null handling mode).
- StringUtils.nullToEmptyNonDruidDataString(pattern),
- indexExpr == null ? DEFAULT_INDEX : ((Number)
indexExpr.getLiteralValue()).intValue(),
- true,
- null
- )
- );
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
