ektravel commented on code in PR #14497: URL: https://github.com/apache/druid/pull/14497#discussion_r1247219548
########## docs/querying/aggregations.md: ########## @@ -422,6 +389,121 @@ It is not possible to determine a priori how well this aggregator will behave fo For these reasons, we have deprecated this aggregator and recommend using the DataSketches Quantiles aggregator instead for new and existing use cases, although we will continue to support Approximate Histogram for backwards compatibility. + +## Expression aggregators Review Comment: Do we need to list both the expression aggregator and the JavaScript aggregator under Expression aggregators? Can we remove line 393 and change line 395 to H2 (## Expression aggregator)? If so, you can add an H3 section called Examples and list all of the expression aggregator examples there. For example: ## Expression aggregator ### Examples ## JavaScript aggregator -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
