gianm commented on code in PR #11201:
URL: https://github.com/apache/druid/pull/11201#discussion_r1247263762
##########
extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchAggregatorFactory.java:
##########
@@ -201,62 +216,64 @@ public Comparator<HllSketch> getComparator()
@Override
public AggregatorFactory getCombiningFactory()
{
- return new HllSketchMergeAggregatorFactory(getName(), getName(), getLgK(),
getTgtHllType(), isRound());
+ return new HllSketchMergeAggregatorFactory(
+ getName(),
+ getName(),
+ getLgK(),
+ getTgtHllType(),
+ getStringEncoding(),
+ isRound()
+ );
}
@Override
public byte[] getCacheKey()
{
- return new
CacheKeyBuilder(getCacheTypeId()).appendString(name).appendString(fieldName)
-
.appendInt(lgK).appendInt(tgtHllType.ordinal()).build();
+ return new CacheKeyBuilder(getCacheTypeId())
+ .appendString(name)
+ .appendString(fieldName)
+ .appendInt(lgK)
+ .appendInt(tgtHllType.ordinal())
+ .appendInt(stringEncoding.ordinal())
Review Comment:
Ahh, we should just do `appendCacheable(stringEncoding)`. I'll change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
