adarshsanjeev commented on code in PR #14512:
URL: https://github.com/apache/druid/pull/14512#discussion_r1250293389
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/resources/SqlStatementResource.java:
##########
@@ -576,12 +587,16 @@ private Optional<ResultSetInformation> getSampleResults(
);
return Optional.of(new ResultSetInformation(
null,
- // since the rows can be sampled, get the number of rows from
counters
- rowsAndSize.orElse(new Pair<>(null, null)).lhs,
- rowsAndSize.orElse(new Pair<>(null, null)).rhs,
dataSource,
// only populate sample results in case a select query is successful
- isSelectQuery ?
SqlStatementResourceHelper.getResults(payload).orElse(null) : null
+ isSelectQuery ?
SqlStatementResourceHelper.getResults(payload).orElse(null) : null,
+ ImmutableList.of(
+ new PageInformation(
+ rowsAndSize.orElse(new Pair<>(null, null)).lhs,
Review Comment:
This might need to be handled at least partially in the next change, as
counters don't really mean anything for results if the destination is the task
report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
