kfaraz opened a new pull request, #14517:
URL: https://github.com/apache/druid/pull/14517
### Bug
__Description:__ If a server is removed during
`HttpServerInventoryView.serverInventoryInitialized`, the initialization gets
stuck as this server is never synced. The method eventually times out (default
250s).
__Fix:__ Mark a server as stopped if it is removed.
`serverInventoryInitialized` only waits for non-stopped servers to sync.
### Changes
- Add new metrics
- `segment/serverview/sync/healthy`: A 1-0 metric that denotes if the
server view is syncing properly with a server
- `segment/serverview/sync/unstableTime`: tracks the time in millis for
which sync with a server has been unstable
- Improve logging in `HttpServerInventoryView` and `ChangeRequestHttpSyncer`
- Refactor for readability
- Add utility class `Stopwatch`
### Pending
- unit tests
- cluster testing
### Release note
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
