LakshSingla opened a new pull request, #14522:
URL: https://github.com/apache/druid/pull/14522
### Description
In MSQ, queries of the following sorts fail:
```
INSERT INTO foo1
SELECT DATE_TRUNC('DAY', CURRENT_TIMESTAMP - INTERVAL '1'DAY) AS __time,
SUM(m1) AS sum_m1
FROM foo
PARTITIONED BY DAY
```
This is a bug in the `GroupByQueryKit` because the absence of the dimensions
causes the query kit to push everything into a single partition (using
`GlobalSortMaxCountShuffleSpec`) however this shuffle spec doesn't support
"buckets", which is needed in case the PARTITIONED BY is present.
The fix involves adding an additional check to ensure that the bucketing is
not present in the clustering columns.
Note 1: There can be multiple fixes for the above, and the current code
should have worked as well if there was no sanity check in the
`GlobalSortMaxCountShuffleSpec` class since we will ultimately get a single row
in all the cases.
Note 2: The query would fail if the time was populated by an aggregator
instead of a post-aggregator (expression)
<hr>
##### Key changed/added classes in this PR
* `GroupByQueryKit`
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
