kfaraz opened a new pull request, #14524:
URL: https://github.com/apache/druid/pull/14524
### Description
After #13197 , several coordinator configs are now redundant as they are not
being used anymore, neither with `smartSegmentLoading` nor otherwise.
### Changes
- Remove dynamic configs `emitBalancingStats`: balancer error stats are
always emitted, debug stats can be logged by using `debugDimensions`
- `useBatchedSegmentSampler`, `percentOfSegmentsToConsiderPerMove`: batched
segment sampling is always used
### Release note
The following Coordinator dynamic configs have been removed:
- `emitBalancingStats`: Stats for errors encountered while balancing will
always be emitted. Other debugging stats will not be emitted but can be logged
by setting the appropriate `debugDimensions`.
- `useBatchedSegmentSampler`, `percentOfSegmentsToConsiderPerMove`: Batched
segment sampling is always on.
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
