LakshSingla opened a new pull request, #14534: URL: https://github.com/apache/druid/pull/14534
### Description Most of the places in MSQ currently rely on the older error code, dating pre https://github.com/apache/druid/pull/14004. This is an attempt to fix the bits of the error code in the places where bits of MSQ reside in the broker. This extends upon the PR https://github.com/apache/druid/pull/14531. 1. The MSQTaskQueryMaker and the MSQTaskEngine might return a different error code for some invalid cases (which might not be inline with what the behavior originally was, but is correct now). For example, setting `maxNumTasks` to 1 would return a 500 error code, which is not right since its an invalid user input. This was the original behavior, and this PR changes that. 2. The EXTERN function returns a 400 error code if the parameters to it are incorrect (which is in line with what its behavior originally was and is correct) Note: This PR doesn't unify the DruidExceptions with the MSQException #### Release note MSQ engine returns correct error codes for invalid user inputs in the query context <hr> This PR has: - [ ] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
